[PATCH] D29211: InferAddressSpaces: Support memory intrinsics

[Justin Lebar via Phabricator via llvm-commits]

jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Transforms/Scalar/InferAddressSpaces.cpp:585
+                               MSI->getLength(), MSI->getAlignment(),
+                               false, TBAA, ScopeMD, NoAliasMD);
+    } else if (MemTransferInst *MTI = dyn_cast<MemTransferInst>(MI)) {
----------------
jlebar wrote:
> Would you mind adding `/*foo=*/false` here and below?  See my now five-year-old screed, http://jlebar.com/2011/12/16/Boolean_parameters_to_API_functions_considered_harmful..html
Not done?


================
Comment at: lib/Transforms/Scalar/InferAddressSpaces.cpp:669
+      Use &U = *I;
+      I = skipToNextUser(I, E);
+
----------------
Could we retain some comment here?


https://reviews.llvm.org/D29211