[PATCH] D29214: [AMDGPU] Internalize non-kernel symbols

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Can we move this into clang/ the compiler driver?



================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:90
+  "amdgpu-internalize-symbols",
+  cl::desc("Enable whole program mode"),
+  cl::init(false),
----------------
Description string needs update


================
Comment at: test/CodeGen/AMDGPU/internalize.ll:7-8
+
+ at gvar_unused = addrspace(1) global i32 undef, align 4
+ at gvar_used = addrspace(1) global i32 undef, align 4
+
----------------
Should this check with various linkage types that should remain visible?


Repository:
  rL LLVM

https://reviews.llvm.org/D29214