[PATCH] D25849: [GVN] Prevent load coercion with irregular vector types

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

I strongly oppose landing a patch that would not pass our usual review standard just because it is in "old" code.  I have made suggestion on how to improve the patch which have not been addressed.  Given that, no I am not okay with this patch landing in it's current form.

To be clear, part of the reason I'm reacting so strongly here is that this is not the first patch this has come up on.  I'm worried about the broader trend as much as I am the particular instance.  Put differently, I'd consider a revised version of this patch with the minor comments addressed and LoadSize handled.  I would prefer to see some discussion of why the alternate approach I asked about isn't worthwhile, but I would not hold the patch just for that.


https://reviews.llvm.org/D25849