[PATCH] D29141: Support of CFG dot dump with layout annotation after MBP pass

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/CodeGen/MachineBlockFrequencyInfo.cpp:117
+    if (!isSimple()) {
+      const MachineFunction *F = Node->getParent();
+      if (!CurFunc || F != CurFunc) {
----------------
davidxl wrote:
> vsk wrote:
> > Can we just use `Node->getNumber()` here? IIUC it's available so long as the MBB is in a MachineFunc, which we appear to be assuming?
> It is tempting but the requires invoking MF.RenumberBlocks() which has side effects. A debug option should not change optimizer behavior.
Oh, I see, MBB.Number starts off as -1 without RenumberBlocks().


https://reviews.llvm.org/D29141