[PATCH] D28913: ThinLTOBitcodeWriter: Strip debug info from merged module.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:265
   std::unique_ptr<Module> MergedM(CloneModule(&M, VMap, IsInMergedM));
+  StripDebugInfo(*MergedM);
 
----------------
pcc wrote:
> mehdi_amini wrote:
> > pcc wrote:
> > > mehdi_amini wrote:
> > > > Debug info is costly to manipulate, can't we have a flag on CloneModule that just ignores them in the first place?
> > > Maybe we can do that in a follow up change. For the moment it seems simplest to strip after cloning.
> > Are you expecting this to be involved? 
> > 
> > 
> We would need to thread the flag through to practically everywhere we create IR when cloning a module. Not that involved but certainly more than a one liner. (And the perf improvement associated with adding the flag hasn't been measured.)
> 
> I've started looking at the bug Ivan found. In the meantime, it would be nice if we could land this change to unbreak our bot.
Which bot? Chromium bot? Why don't you patch this internally?



https://reviews.llvm.org/D28913