[PATCH] D29169: Do not apply redundant LastCallToStaticBonus

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 11:34:38 PST 2017


eraman added a comment.

The change looks fine, but this is an instance where fixing a bug causes a regression :( See my comments in a different bug at https://reviews.llvm.org/D21405#461421 . Could you do size comparison with this patch on some benchmarks and post it here for reference?



================
Comment at: test/Transforms/Inline/last-call-bonus.ll:1
+; RUN: opt < %s -loop-unroll -inline -unroll-threshold=15000 -inline-threshold=250 -S | FileCheck %s
+; CHECK-LABEL: define internal i32 @bar()
----------------
Leave a comment on why you are doing the unrolling with high unroll factor


https://reviews.llvm.org/D29169





More information about the llvm-commits mailing list