getScalarizationOverhead(), revisited

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 05:47:39 PST 2017


Hi Hal,

Thanks for review the other day of my patch on getScalarizationOverhead().

After getting that approved, I took another look over places where this 
method is called. I found at least one more case that I could fix. It 
was in LoopVectorizer.cpp - see patch. Changing this also gave as a 
bonus effect the elimination of one more wrapper function for this.

I think it may be possible also to improve this in 
getIntrinsicInstrCost(), if we extend the parameter list to pass the 
arguments or the instruction itself. I am not sure though how needed 
this is - it seems quite rare.

Does this patch look ok?

/Jonas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: getScalarizationOH_LoopVec_revisited.patch
Type: text/x-patch
Size: 1550 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170127/8764433d/attachment.bin>


More information about the llvm-commits mailing list