[PATCH] D28836: [tsan] Provide API for libraries for race detection on custom objects

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

In https://reviews.llvm.org/D28836#655410, @kubamracek wrote:

> > But please post full reports for the tests.
>
> What exactly would you like to see?  The TSan output for the lit test that's part of the patch?  Or the TSan output for a more realistic use case?


For the test.



================
Comment at: lib/tsan/rtl/tsan_external.cc:51
+  if (b) {
+    b->tag = (u32)(uptr)tag;
+  }
----------------
What is it u32?
I could understand u16 and u64, or not cast at all. But u32 looks confusing.
I would just remove the (u32) cast.


https://reviews.llvm.org/D28836