[PATCH] D29213: InferAddressSpaces: Handle icmp

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Transforms/Scalar/InferAddressSpaces.cpp:747
+
+          if (Value *OtherNewV = ValueWithNewAddrSpace.lookup(OtherSrc)) {
+            Cmp->setOperand(OtherIdx, OtherNewV);
----------------
jlebar wrote:
> I don't see where we check that NewV and OtherNewV have the same AS.  Shouldn't it be right here?
> 
> Sorry if it's obvious; I'm breaking my rule against reviewing patches late at night, and may be embarrassed in the morning.
I was confused about what you were saying, but the check turns out to have been added in the patch I forgot to squash which fixed that bug


https://reviews.llvm.org/D29213