[PATCH] D29213: InferAddressSpaces: Handle icmp

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 23:49:36 PST 2017


arsenm added a comment.

In https://reviews.llvm.org/D29213#658543, @jlebar wrote:

> Well this one is interesting.
>
> I think I see what you're getting at here; if we can ASC away all uses of a generic pointer except the icmp, then keeping around the generic pointers in icmp is just unnecessary register pressure.
>
> But at least on NVPTX, I think this is only safe if we can transform *both* pointers in the icmp, and moreover only if both pointers are transformed to the same AS.


The IR type system requires both be the same type, so this is done here. Also I just noticed I forgot to update the TODO saying to do this


https://reviews.llvm.org/D29213





More information about the llvm-commits mailing list