[PATCH] D29164: NVPTX: Refactor NVPTXInferAddressSpaces to check TTI

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:236
+  /// address space.
+  unsigned getUndesirableAddressSpace() const;
+
----------------
jlebar wrote:
> jlebar wrote:
> > Maybe I'm biased because I'm coming from the CUDA world, but "undesirable" doesn't really seem to capture what's going on as well as 'generic'., and indeed the comment uses "generic" to good effect.
> > 
> > What are you trying to get across with the name, exactly?
> Maybe this should return optional<unsigned>?
I was trying to avoid a second meaning of the term generic address space. LLVM already unfortunately clobbers the meaning of "generic" address space to mean addrspace(0) and all the assumptions it makes about it. This is generic/flat in a GPU world sense


https://reviews.llvm.org/D29164