[PATCH] D29165: NVPTX: Trivial cleanups of NVPTXInferAddressSpaces

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 17:16:16 PST 2017


arsenm added inline comments.


================
Comment at: lib/Target/NVPTX/NVPTXInferAddressSpaces.cpp:472
     // address spaces of its operands.
-    DEBUG(dbgs() << "Updating the address space of\n"
-                 << "  " << *V << "\n");
+    DEBUG(dbgs() << "Updating the address space of\n  " << *V << '\n');
     Optional<unsigned> NewAS = updateAddressSpace(*V, *InferredAddrSpace);
----------------
jlebar wrote:
> I don't really care, but I have to admit that I find '\n' in place of "\n" kind of a strange change to make.
I think it looks nicer and allegedly this saves a call by using the more inlinable char version of <<


https://reviews.llvm.org/D29165





More information about the llvm-commits mailing list