[PATCH] D29173: [LoopUnroll] Use addClonedBlockToLoopInfo to clone the top level loop (NFC)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 16:13:55 PST 2017


fhahn added inline comments.


================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:389
   }
-  if (NewLoop) {
+  if (Loop *NewLoop = NewLoops[L]) {
     // Add unroll disable metadata to disable future unrolling for this loop.
----------------
mkuper wrote:
> Are you sure you want to do this if NewLoops[L] is the parent loop? I think this code is meant to only disable unrolling on the remainder loop.
Ah good spot. We should check CreateRemainderLoop I think.


https://reviews.llvm.org/D29173





More information about the llvm-commits mailing list