[PATCH] D29045: [PGO] Add option to dot-dump raw profile counts as computed by profile annotator

[Rong Xu via Phabricator via llvm-commits]

xur accepted this revision.
xur added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1331
+    OS << Node->getName().str() << " : ";
+    UseBBInfo *BI = Graph->findBBInfo(Node);
+    if (BI->CountValid)
----------------
davidxl wrote:
> xur wrote:
> > Check if BI is null. If the Node is not reachable from entry. We don't have a UseBBInfo.
> Added check. How can that happen?
We construct the Minimum spanning tree starting the entry node. An reachable BB (not clean up) will be left out without being touched. This is race, but does happen in some constructed .ll files.


https://reviews.llvm.org/D29045