[PATCH] D29094: Add verbose printing of line info in LLVM Symbolizer

[Simon Que via Phabricator via llvm-commits]

sque added inline comments.


================
Comment at: lib/DebugInfo/Symbolize/DIPrinter.cpp:85
+    OS << "  Column: " << Info.Column << "\n";
+    OS << "  Discriminator: " << Info.Discriminator << "\n";
+  } else {
----------------
dblaikie wrote:
> sque wrote:
> > Should this be marked as DWARF-only, or placed in a DWARF-only section?
> I'm /guessing/ (though you can probably reproduce this by running -verbose on a checked in COFF/CodeView file - I assume/imagine we have some of those in the dumper testing) that the Discriminator is 0 when not provided?
> 
> Perhaps it'd be easy enough to not print it when it's zero? If that works/you can confirm CodeView is doing what I assume it is - add a test? (for either CV, or a case a zero or not present discriminator in ELF).
I am not familiar with possible values of the discriminator. Does discriminator == 0 mean it's invalid? Could it have a valid value of 0?


https://reviews.llvm.org/D29094