[PATCH] D29170: [ELF] - Remove unnessesary checks from GC logic.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 13:36:19 PST 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
>    // Mark the piece at a given offset live. Used by GC.
> +  // We always keep whole non-alloc sections (usually debug ones).
>    void markLiveAt(uintX_t Offset) {
> -    assert(this->Flags & llvm::ELF::SHF_ALLOC);
> -    LiveOffsets.insert(Offset);
> +    if (this->Flags & SHF_ALLOC)
> +      LiveOffsets.insert(Offset);
>    }

When is markLiveAt called in an non alloc section now? If the section
Live bit was already set, this should not have been called, no?

Cheers,
Rafael


More information about the llvm-commits mailing list