D28094: [ELF] - Implemented support for R_386_PC8/R_386_8 relocations.

[Rui Ueyama via llvm-commits]

But we already have the same assignment
in X86_64TargetInfo<ELFT>::relocateOne, so I guess we've accepted that?

On Thu, Jan 26, 2017 at 12:51 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> >================
> >Comment at: lld/trunk/ELF/Target.cpp:518
> >+  if (Type == R_386_8 || Type == R_386_PC8) {
> >+    *Loc = (uint8_t)Val;
> >+    return;
> >----------------
> >Do you need a cast?
>
> I think we want it.
>
> Otherwise with clang's -Weverything/-Wconversion it should give something
> like
> "warning: implicit conversion loses integer precision: 'uint64_t' (aka
> 'unsigned long') to 'uint8_t' (aka 'unsigned char') [-Wconversion]"
>
> George.
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170126/deed6e93/attachment.html>