[PATCH] D29170: [ELF] - Remove unnessesary checks from GC logic.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 11:39:16 PST 2017


davide added a comment.

In https://reviews.llvm.org/D29170#657896, @ruiu wrote:

> I don't know if this is making things better - it seems neutral to me or an unnecessary churn.




In https://reviews.llvm.org/D29170#657896, @ruiu wrote:

> I don't know if this is making things better - it seems neutral to me or an unnecessary churn.


Same. I'm actually a bit confused about this refactoring. First we had the logic in a single place and now we moved part of it to `InputSection.{cpp,h}` (i.e. the assertion became an if).


https://reviews.llvm.org/D29170





More information about the llvm-commits mailing list