[PATCH] D29161: [APFloat] Reduce some dispatch boilerplates. NFC.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 10:27:21 PST 2017


jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.

Other than the naming nit, this seems like an improvement to me.



================
Comment at: llvm/include/llvm/ADT/APFloat.h:24
 
+#define APFLOAT_SINGLE_DISPATCH(METHOD_CALL)                                   \
+  do {                                                                         \
----------------
What does "single" refer to here?

APFLOAT_SEMANTIC_DISPATCH?  I don't really like that either.

Maybe someone else has a better suggestion.


https://reviews.llvm.org/D29161





More information about the llvm-commits mailing list