[PATCH] D29185: Allow llvm's build and test systems to support paths with spaces

[Greg Bedwell via Phabricator via llvm-commits]

gbedwell added a comment.

> I also ran the lit testsuite on Linux (It doesn't work on windows.)

Can you clarify what you mean by this?  Are you referring to test-suite ( http://llvm.org/docs/TestingGuide.html#test-suite ) or something else?



================
Comment at: docs/GettingStartedVS.rst:60
+in test failures as tests are sometimes written which do not work in this
+scenario.
 
----------------
I'm not convinced by this message.  LLVM as a whole includes various different projects which new users may come to expect from this document to also work in paths with spaces, but AFAICT this commit only affects the base llvm project itself.  I'm also not entirely comfortable with the idea that it's essentially saying "it may work, unless we break it".  I make no judgement as to whether it's worth making everything work with paths with spaces, but we should probably err on the side of caution and just document that it's not supported if we can't guarantee it.


https://reviews.llvm.org/D29185