[PATCH] D28571: RuntimeDyldELF/AArch64: Implement basic support for PIC relocations

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

I think that those changes address my previous comments, thanks for the update. I've found a couple of what look like typos in the comments. I'm not familiar with rtdyld's organizational and coding conventions so probably best that let an owner take it from here.



================
Comment at: test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_PIC_relocations.s:24
+
+## Test that .got section has two entries pointing to f, g and _s
+# *{8}section_addr(pic-reloc.o, .got) = f
----------------
do you mean "three entries pointing to f, g, and _s"?


https://reviews.llvm.org/D28571