[PATCH] D29170: [ELF] - Remove unnessesary checks from GC logic.

[Davide Italiano via Phabricator via llvm-commits]

davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

Do we have a test to make sure sections containing debug info (marked as !SHF_ALLOC) are not reclaimed? I'm a little bit worried because this broke already in the past.



================
Comment at: ELF/MarkLive.cpp:159-161
-// We do not garbage-collect two types of sections:
-// 1) Sections used by the loader (.init, .fini, .ctors, .dtors or .jcr)
-// 2) Non-allocatable sections which typically contain debugging information
----------------
Why did you change this comment?
We still shouldn't reclaim !SHF_ALLOC sections as they can contain debug infos


https://reviews.llvm.org/D29170