[PATCH] D29129: [LLD][ELF] Use Synthetic Sections for Thunks

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 05:13:51 PST 2017


peter.smith updated this revision to Diff 85886.
peter.smith added a comment.

Thanks very much for the comments.

I've updated the diff to apply the changes. I wasn't able to find a way to reduce the indentation createThunks by inverting some the if statements. 
What I've done instead is extracted the main operations into lambdas. This hopefully makes the main loop processing relocations easier to follow.


https://reviews.llvm.org/D29129

Files:
  ELF/InputFiles.cpp
  ELF/InputSection.cpp
  ELF/InputSection.h
  ELF/LTO.cpp
  ELF/LTO.h
  ELF/Relocations.cpp
  ELF/Relocations.h
  ELF/SymbolTable.cpp
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h
  ELF/Target.cpp
  ELF/Target.h
  ELF/Thunks.cpp
  ELF/Thunks.h
  ELF/Writer.cpp
  test/ELF/arm-thumb-interwork-shared.s
  test/ELF/arm-thumb-interwork-thunk.s
  test/ELF/mips-npic-call-pic.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29129.85886.patch
Type: text/x-patch
Size: 72981 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170126/d9263ba1/attachment.bin>


More information about the llvm-commits mailing list