[polly] r293169 - [ScopDetectionDiagnostic] Add meaningfull enduser message for regions with entry block

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 02:41:38 PST 2017


Author: grosser
Date: Thu Jan 26 04:41:37 2017
New Revision: 293169

URL: http://llvm.org/viewvc/llvm-project?rev=293169&view=rev
Log:
[ScopDetectionDiagnostic] Add meaningfull enduser message for regions with entry block

Before this change the user only saw "Unspecified Error", when a region
contained the entry block. Now we report:

"Scop contains function entry (not yet supported)."

Modified:
    polly/trunk/include/polly/ScopDetectionDiagnostic.h
    polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp

Modified: polly/trunk/include/polly/ScopDetectionDiagnostic.h
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/ScopDetectionDiagnostic.h?rev=293169&r1=293168&r2=293169&view=diff
==============================================================================
--- polly/trunk/include/polly/ScopDetectionDiagnostic.h (original)
+++ polly/trunk/include/polly/ScopDetectionDiagnostic.h Thu Jan 26 04:41:37 2017
@@ -702,6 +702,7 @@ public:
   /// @name RejectReason interface
   //@{
   virtual std::string getMessage() const override;
+  virtual std::string getEndUserMessage() const override;
   virtual const DebugLoc &getDebugLoc() const override;
   //@}
 };

Modified: polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp?rev=293169&r1=293168&r2=293169&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp (original)
+++ polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp Thu Jan 26 04:41:37 2017
@@ -549,6 +549,10 @@ std::string ReportEntry::getMessage() co
   return "Region containing entry block of function is invalid!";
 }
 
+std::string ReportEntry::getEndUserMessage() const {
+  return "Scop contains function entry (not yet supported).";
+}
+
 const DebugLoc &ReportEntry::getDebugLoc() const {
   return BB->getTerminator()->getDebugLoc();
 }




More information about the llvm-commits mailing list