[PATCH] D29050: [zorg] Add AOSP builder

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 02:03:02 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D29050#655922, @srhines wrote:

> Are you sure that you want to always be syncing AOSP? There is a good chance that the AOSP build could break for reasons beyond the control of the LLVM community. It might be better to pick a particular AOSP release to minimize those kinds of issues. One other potential problem is going to be the increasing presence of stricter warnings/errors from Clang. These can also cause issues with AOSP.


Hi Steve,

Do you have a marker for "good" reviews? This could either be a tag or branch, but it could also be the result of some public buildbot being green.

If there isn't an easy way to do this, I agree that sticking to a known release is better, but with the caveat that the bot manager manually changes the revision every time there's a new stable.

It isn't very helpful to know we can build AOSP a year ago. :)

cheers,
--renato


https://reviews.llvm.org/D29050





More information about the llvm-commits mailing list