[PATCH] D28502: [compiler-rt] [Interception] Properly check for export table's size before referring to its elements.

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 22:03:32 PST 2017


kubamracek reopened this revision.
kubamracek added a comment.
This revision is now accepted and ready to land.

This was reverted, so reopening.  Were there bot failures?

Also, I might be late to the party, but I don't think adding a new test suite for this it a good idea.  Lit tests are supposed to be "user code".  Your test includes an internal header file and calls an internal function.  Can you reproduce the issue in a "user code"-type test (how did you hit the issue in the first place)?  And can you put it into an existing test suite, e.g. into `test/asan/TestCases/Windows/`?


Repository:
  rL LLVM

https://reviews.llvm.org/D28502





More information about the llvm-commits mailing list