[PATCH] D29150: Add --warn-unresolved-symbols and --error-unresolved-symbols options

Wed Jan 25 16:27:52 PST 2017

Sending from the right account…

From: Dmitry Mikulin
Reply-To: Dmitry Mikulin
Date: Wednesday, January 25, 2017 at 4:13 PM
To: Rafael Avila de Espindola, "reviews+D29150+public+4e541d09c9d4e079 at reviews.llvm.org<mailto:reviews+D29150+public+4e541d09c9d4e079 at reviews.llvm.org>", "dccitaliano at gmail.com<mailto:dccitaliano at gmail.com>", "bigcheesegs at gmail.com<mailto:bigcheesegs at gmail.com>", "ruiu at google.com<mailto:ruiu at google.com>", Dmitry Mikulin
Cc: "llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>", "adhemerval.zanella at linaro.org<mailto:adhemerval.zanella at linaro.org>"
Subject: Re: [PATCH] D29150: Add --warn-unresolved-symbols and --error-unresolved-symbols options

%p/Inputs/unresolved-symbols.s already exists, I reused it for this test.
I'll add -shared test points.

________________________________
From: Rafael Avila de Espindola <rafael.espindola at gmail.com<mailto:rafael.espindola at gmail.com>>
To: reviews+D29150+public+4e541d09c9d4e079 at reviews.llvm.org<mailto:reviews+D29150+public+4e541d09c9d4e079 at reviews.llvm.org>; mikdm at yahoo.com<mailto:mikdm at yahoo.com>; dccitaliano at gmail.com<mailto:dccitaliano at gmail.com>; bigcheesegs at gmail.com<mailto:bigcheesegs at gmail.com>; ruiu at google.com<mailto:ruiu at google.com>
Cc: llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>; adhemerval.zanella at linaro.org<mailto:adhemerval.zanella at linaro.org>
Sent: Wednesday, January 25, 2017 3:31 PM
Subject: Re: [PATCH] D29150: Add --warn-unresolved-symbols and --error-unresolved-symbols options

> +# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/unresolved-symbols.s -o %t2.o

%p/Inputs/unresolved-symbols.s is missing from the patch.

Please add a test with -shared too to document the behavior: no warning/error.

Cheers,
Rafael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170126/d25ca4de/attachment.html>