Critical XRay fixes for Arm32

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 16:26:41 PST 2017


Hi Dean, Renato,

AFAIK, unfortunately, these critical Arm32 XRay fixes are not yet in 4.0:
https://reviews.llvm.org/D28624 , https://reviews.llvm.org/D28623 . The
first repairs XRay instrumentation map emission. Without this map XRay
doesn't work at all: the runtime doesn't see anything to instrument. The
second fixes the CPU cache incoherency problem. Without this patch, XRay
will intermittently fail to patch or unpatch some sleds (depending on
whether their code is in CPU cache or not).

Is there any chance we can get these patches to 4.0? This page
http://llvm.org/docs/HowToReleaseLLVM.html#release-patch-rules says that
"release manager, the official release testers or the code owners" may
approve cherry-picking to release branch from trunk. AFAIK, you are code
owners for XRay and ARM. I don't know who are the release manager or
official release testers.

Cheers,
Serge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170126/46a7269e/attachment.html>


More information about the llvm-commits mailing list