[PATCH] D27874: ilist_iterator: Allow conversion between reverse and forward iterators

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 15:32:48 PST 2017


MatzeB abandoned this revision.
MatzeB added a comment.

I wasn't aware of the subtle shift-by-1 semantics when converting to std::reverse_iterator (must have missed the getReverse() comment). If we go with that semantics I would need extra std::next/std::prev calls in my code anyway which doesn't make it much simpler compared to MyIterator->getReverseIterator(). Going for semantics different from STL is not a good idea IMO.


Repository:
  rL LLVM

https://reviews.llvm.org/D27874





More information about the llvm-commits mailing list