[PATCH] D28300: [InstCombine] Fix address space handling when removing allocas

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

Is this optimization safe in general if the address spaces don't match? Could, for example, some of the users being affected be some target-specific intrinsic that is only valid for certain address spaces?



================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:503
+      } else {
+        assert(false && "Can't update address space for this instruction");
+      }
----------------
llvm_unreachable


https://reviews.llvm.org/D28300