[PATCH] D29149: NewGVN: Add basic dead store elimination

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added inline comments.


================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:2223
+          // We ignore void things because we can't get a value from them.
+          if (Member && Member->getType()->isVoidTy()) {
+            continue;
----------------
I'll remove the {'s.



================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:2273
+            PossibleDeadStores.push_back(VD);
+
           // Skip the Value's, we only want to eliminate on their uses.
----------------
This is leftover from when i was trying to only walk the members once, but harmless.
removing it.


https://reviews.llvm.org/D29149