[PATCH] D29145: [NewGVN] Skip uses in unreachable blocks

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 14:27:38 PST 2017


dberlin added inline comments.


================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:1946
+          continue;
+
         DomTreeNode *DomNode = DT->getNode(IBlock);
----------------
Do you need this lookup?
Won't localnum already be 0, because we now zero the dfs number for uses in unreachable blocks?



https://reviews.llvm.org/D29145





More information about the llvm-commits mailing list