[PATCH] D28596: [compiler-rt] General definition for weak functions.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 14:05:02 PST 2017


mpividori updated this revision to Diff 85804.
mpividori added a comment.

@rnk Ok, I realized you are right, we can remove `WEAK_DECL` and continue using declarations like: `void SANITIZER_WEAK_ATTRIBUTE ...` , because we only need to refer to the exported function "fun__dll" on a linker pragma `WEAK_ALIAS(...)`, so we don't need a declaration.
So, now, I only define a macro "WEAK_DEF()".
Thanks.


https://reviews.llvm.org/D28596

Files:
  lib/asan/asan_allocator.cc
  lib/asan/asan_flags.cc
  lib/asan/asan_report.cc
  lib/asan/asan_suppressions.cc
  lib/asan/asan_win.cc
  lib/sanitizer_common/sancov_flags.cc
  lib/sanitizer_common/sanitizer_common.cc
  lib/sanitizer_common/sanitizer_coverage_libcdep.cc
  lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc
  lib/sanitizer_common/sanitizer_internal_defs.h
  lib/sanitizer_common/sanitizer_printf.cc
  lib/sanitizer_common/sanitizer_win.cc
  lib/sanitizer_common/sanitizer_win_defs.h
  lib/ubsan/ubsan_flags.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28596.85804.patch
Type: text/x-patch
Size: 16981 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170125/7a8d51d5/attachment-0001.bin>


More information about the llvm-commits mailing list