[llvm] r293092 - Revert "[PPC] Give unaligned memory access lower cost on processor that supports it"

[Daniel Jasper via llvm-commits]

Author: djasper
Date: Wed Jan 25 15:21:08 2017
New Revision: 293092

URL: http://llvm.org/viewvc/llvm-project?rev=293092&view=rev
Log:
Revert "[PPC] Give unaligned memory access lower cost on processor that supports it"

This reverts commit r292680. It is causing significantly worse
performance and test timeouts in our internal builds. I have already
routed reproduction instructions your way.

Removed:
    llvm/trunk/test/Analysis/CostModel/PowerPC/unaligned_ld_st.ll
Modified:
    llvm/trunk/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
    llvm/trunk/test/Analysis/CostModel/PowerPC/load_store.ll

Modified: llvm/trunk/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCTargetTransformInfo.cpp?rev=293092&r1=293091&r2=293092&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCTargetTransformInfo.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCTargetTransformInfo.cpp Wed Jan 25 15:21:08 2017
@@ -401,10 +401,6 @@ int PPCTTIImpl::getMemoryOpCost(unsigned
   if (IsVSXType || (ST->hasVSX() && IsAltivecType))
     return Cost;
 
-  // Newer PPC supports unaligned memory access.
-  if (TLI->allowsMisalignedMemoryAccesses(LT.second, 0))
-    return Cost;
-
   // PPC in general does not support unaligned loads and stores. They'll need
   // to be decomposed based on the alignment factor.
 

Modified: llvm/trunk/test/Analysis/CostModel/PowerPC/load_store.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/CostModel/PowerPC/load_store.ll?rev=293092&r1=293091&r2=293092&view=diff
==============================================================================
--- llvm/trunk/test/Analysis/CostModel/PowerPC/load_store.ll (original)
+++ llvm/trunk/test/Analysis/CostModel/PowerPC/load_store.ll Wed Jan 25 15:21:08 2017
@@ -1,4 +1,4 @@
-; RUN: opt < %s  -cost-model -analyze -mtriple=powerpc64-unknown-linux-gnu -mcpu=g5 -disable-ppc-unaligned | FileCheck %s
+; RUN: opt < %s  -cost-model -analyze -mtriple=powerpc64-unknown-linux-gnu -mcpu=g5 | FileCheck %s
 target datalayout = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64"
 target triple = "powerpc64-unknown-linux-gnu"
 

Removed: llvm/trunk/test/Analysis/CostModel/PowerPC/unaligned_ld_st.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/CostModel/PowerPC/unaligned_ld_st.ll?rev=293091&view=auto
==============================================================================
--- llvm/trunk/test/Analysis/CostModel/PowerPC/unaligned_ld_st.ll (original)
+++ llvm/trunk/test/Analysis/CostModel/PowerPC/unaligned_ld_st.ll (removed)
@@ -1,26 +0,0 @@
-; RUN: opt < %s -cost-model -analyze -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr8 -mattr=+vsx | FileCheck %s
-target datalayout = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64"
-target triple = "powerpc64-unknown-linux-gnu"
-
-define i32 @test(i32 %arg) {
-
-  ; CHECK: cost of 1 {{.*}} load
-  load i8, i8* undef, align 1
-  ; CHECK: cost of 1 {{.*}} load
-  load i16, i16* undef, align 1
-  ; CHECK: cost of 1 {{.*}} load
-  load i32, i32* undef, align 1
-  ; CHECK: cost of 1 {{.*}} load
-  load i64, i64* undef, align 1
-
-  ; CHECK: cost of 1 {{.*}} store
-  store i8 undef, i8* undef, align 1
-  ; CHECK: cost of 1 {{.*}} store
-  store i16 undef, i16* undef, align 1
-  ; CHECK: cost of 1 {{.*}} store
-  store i32 undef, i32* undef, align 1
-  ; CHECK: cost of 1 {{.*}} store
-  store i64 undef, i64* undef, align 1
-
-  ret i32 undef
-}