[lld] r293089 - Remove useless cast and update a comment.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 25 13:05:17 PST 2017
Author: ruiu
Date: Wed Jan 25 15:05:17 2017
New Revision: 293089
URL: http://llvm.org/viewvc/llvm-project?rev=293089&view=rev
Log:
Remove useless cast and update a comment.
Modified:
lld/trunk/ELF/Target.cpp
Modified: lld/trunk/ELF/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=293089&r1=293088&r2=293089&view=diff
==============================================================================
--- lld/trunk/ELF/Target.cpp (original)
+++ lld/trunk/ELF/Target.cpp Wed Jan 25 15:05:17 2017
@@ -512,17 +512,15 @@ void X86TargetInfo::relocateOne(uint8_t
uint64_t Val) const {
checkInt<32>(Loc, Val, Type);
- // R_386_PC16/R_386_16/R_386_PC8/R_386_8 are not part of the current i386
- // psABI. They are used by 16-bit x86 objects, like boot loaders.
- if (Type == R_386_8 || Type == R_386_PC8) {
- *Loc = (uint8_t)Val;
- return;
- }
- if (Type == R_386_16 || Type == R_386_PC16) {
+ // R_386_{PC,}{8,16} are not part of the i386 psABI, but they are
+ // being used for some 16-bit programs such as boot loaders, so
+ // we want to support them.
+ if (Type == R_386_8 || Type == R_386_PC8)
+ *Loc = Val;
+ else if (Type == R_386_16 || Type == R_386_PC16)
write16le(Loc, Val);
- return;
- }
- write32le(Loc, Val);
+ else
+ write32le(Loc, Val);
}
void X86TargetInfo::relaxTlsGdToLe(uint8_t *Loc, uint32_t Type,
More information about the llvm-commits
mailing list