[PATCH] D28920: DAG: Allow targets to override stack temp alignment

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 12:57:51 PST 2017


arsenm added a comment.

In https://reviews.llvm.org/D28920#656679, @hfinkel wrote:

> > The DataLayout's preferred alignment cannot be lower than the ABI required alignment, which defaults to the type size
>
> Why not change that?


I thought about that, but it seems like a risky, IR breaking change. I assume most places using this are using this to get a bigger alignment than required and assuming it is a legal ABI alignment. In codegen there is more freedom to decide what the ABI really means. I can try changing this and see what breaks.


https://reviews.llvm.org/D28920





More information about the llvm-commits mailing list