[PATCH] D29050: [zorg] Add AOSP builder

[Pengxuan Zheng via Phabricator via llvm-commits]

pzheng added a comment.

In https://reviews.llvm.org/D29050#655922, @srhines wrote:

> Are you sure that you want to always be syncing AOSP? There is a good chance that the AOSP build could break for reasons beyond the control of the LLVM community. It might be better to pick a particular AOSP release to minimize those kinds of issues. One other potential problem is going to be the increasing presence of stricter warnings/errors from Clang. These can also cause issues with AOSP.


Thanks for bring this up. These are indeed valid concerns. Can you please suggest an AOSP release for use with this buildbot?



================
Comment at: zorg/buildbot/builders/AOSPBuilder.py:84
+                           description=["install llvm"],
+                           workdir=llvm_objdir))
+
----------------
grosser wrote:
> pzheng wrote:
> > grosser wrote:
> > > Why do you need to list these steps again? Can you not just use include the normal Polly bullder (that you recently extended to allow the installation of clang)?
> > These steps are included in getPollyBuildFactory, but can not be directly used here since getPollyBuildFactory returns a BuildFactory. We can certainly do some refactoring of the code in PollyBuilder.py to make some of the code reusable by both the Polly Builder and AOSP Builder if that makes more sense to you.
> Why can you not just add more steps to the BuildFactory returned by getPollyBuildFactory.
> 
> getPollyLNTFactory() does this. It uses a function addLNTTestsToFactory, but as we add only steps at the end, this might not even be needed. And yes, I think avoiding code duplication makes sense here.
Sure, I will make the change probably along with the one suggested by Stephen.


================
Comment at: zorg/buildbot/builders/AOSPBuilder.py:101
+    if target_clang:
+        command += " TARGET_CLANG=%s" % target_clang
+    if target_flags:
----------------
srhines wrote:
> You can switch from TARGET_CLANG to LLVM_PREBUILTS_BASE along with LLVM_PREBUILTS_VERSION. You might also need to set/adjust LLVM_RELEASE_VERSION (currently 4.0, but obviously upstream will move past that).
Thanks for your suggestion. Have a couple of questions.
1) TARGET_CLANG only switches the Clang used for target build. Host build still uses the AOSP's default Clang. Can I have the same effect by using LLVM_PREBUILTS_BASE & LLVM_RELEASE_VERSION?
2) Can you please give an example of how to use LLVM_PREBUILTS_BASE & LLVM_RELEASE_VERSION to switch the Clang for build AOSP? Let's assume the Clang we want to switch to is located at /local/aosp/llvm.inst/bin/clang(++).


https://reviews.llvm.org/D29050