[PATCH] D29110: LangRef: Document the allowed metadata dropping transforms.

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added a comment.

Hi,

Generally I agree with Mehdi and Krzysztof.

I'm also not a big fan of making it "too easy" to add arbitrary semantic attributes to the IR (I think the current design of function attributes is lacking, in this respect).  Adding new semantic properties to IR constructs _should_ be a "heavyweight" (of course, up to a point) operation to discourage poorly thought out potentially non-orthogonal design (to be clear, I'm not insinuating the type, absolute_symbol etc. properties are poorly thought out -- I don't have an opinion on them at the moment).


https://reviews.llvm.org/D29110