[PATCH] D29110: LangRef: Document the allowed metadata dropping transforms.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D29110#656551, @kparzysz wrote:

> In https://reviews.llvm.org/D29110#656480, @pcc wrote:
>
> > So would it solve the problem if we don't call it metadata? They are "attributes which happen to be represented using the MD* classes".
>
>
> Would it still look like metadata to someone who has not read that piece of documentation?  Would this information invalidate previously correct understanding of the IR?
>
> Imagine that some user somewhere wrote their own LLVM-based compiler that strips all metadata.  If that compiler generated a correct code prior to this change, would it potentially generate a wrong code afterwards?


I agree and I see this as a problem: writing a pass that would strip all the metadata attachment would not be correct anymore.


https://reviews.llvm.org/D29110