[PATCH] D28307: Add Instruction number to LSR cost model (PR23384) part 1 of 3

[Evgeny Stupachenko via Phabricator via llvm-commits]

evstupac added inline comments.


================
Comment at: test/Transforms/LoopStrengthReduce/X86/lsr-insns-1.ll:14
+
+; CHECK: 7 asm-printer      - Number of machine instrs printed
+
----------------
hfinkel wrote:
> Ah, okay. You're just counting the total number of instructions. Please actually match the desired output instruction pattern. Otherwise these tests will be fragile to unrelated changes.
Well, the tests are really small and simple.
I expect more fragility from instruction pattern.
Anyway, if any change will increase instruction count here it would be a bad sign and the change author should pay attention to this.



Repository:
  rL LLVM

https://reviews.llvm.org/D28307