[PATCH] D27792: IfConversion: Use reverse_iterator to simplify. NFC

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sure - not sure what Duncan's preference is here, or the ultimate end goal re: consistency, etc, is, though.



================
Comment at: lib/CodeGen/IfConversion.cpp:647
+  // We have to do our own shifting so that we get the same range.
+  MachineBasicBlock::reverse_iterator RTIE = std::next(TIE.getReverse());
+  MachineBasicBlock::reverse_iterator RFIE = std::next(FIE.getReverse());
----------------
This construct is used rather than this:

  MachineBasicBlock::reverse_iterator RTIE = TIE;

to avoid depending on that conversion & it's subtle off-by-one jump?


https://reviews.llvm.org/D27792