ruiu added inline comments. ================ Comment at: lld/trunk/ELF/Target.cpp:518 + if (Type == R_386_8 || Type == R_386_PC8) { + *Loc = (uint8_t)Val; + return; ---------------- Do you need a cast? Repository: rL LLVM https://reviews.llvm.org/D28094