[PATCH] D28249: Improve scheduling with branch coalescing

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 08:46:03 PST 2017


lei marked an inline comment as done.
lei added inline comments.


================
Comment at: lib/CodeGen/BranchCoalescing.cpp:442
+    for (auto &Def : MI.defs()) { // Looking at Def
+      if (Def.isReg())            // could it be anything else?
+        for (auto &Use : MRI->use_instructions(Def.getReg())) {
----------------
nemanjai wrote:
> I don't understand the purpose of the comment.
will remove this redundant check since MI.defs() return register definitions.


https://reviews.llvm.org/D28249





More information about the llvm-commits mailing list