[PATCH] D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 07:45:58 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D29124#656277, @mboehme wrote:

> Apologies -- I was under the impression that post-commit review also involved uploading the patch to Phabricator. I understand now that this is not the case?
>
> My intention here was to obtain a post-commit review from rovka but also to make it clear that bkramer had looked at the change. But I obviously didn't follow the usual process here -- sorry for this, I didn't mean to cause any aggravation or confusion.


No worries. No aggravation caused, only confusion. :)

Most of us subscribe to llvm-commits (et al), and filter by the keywords we care ("arm", "aarch64", etc.), so we see all the patches that go though.

If the fix is small and obvious, a direct commit is fine, as long as you explain what you can about what the bug does, how it's being tested, where it came from, etc.

All in all, no hard feelings. :)

cheers,
--reato


Repository:
  rL LLVM

https://reviews.llvm.org/D29124





More information about the llvm-commits mailing list