[PATCH] D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug.

Benjamin Kramer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 06:50:23 PST 2017


bkramer added a comment.

In https://reviews.llvm.org/D29124#656224, @rengolin wrote:

> Though, hum, hard to make tests for that...


It's covered by existing tests. ASAN catches it with -fsanitize-address-use-after-scope, which is not on by default yet afaik.

> OTOH, why push a public review if the review was done internally anyway?

So other people have a chance to chime in? I'd argue that this change is below the triviality threshold for post-commit review though.


Repository:
  rL LLVM

https://reviews.llvm.org/D29124





More information about the llvm-commits mailing list