[PATCH] D28094: [ELF] - Implemented support for R_386_PC8/R_386_8 relocations.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Target.cpp:493
+  case R_386_PC8:
+    return read<uint8_t, endianness::little>(Buf);
   case R_386_16:
----------------
ruiu wrote:
> No such thing like a one byte little endian value as the endianness is inherently a concept when you have more than one byte, so don't use read<>. That's why we don't have read8{be,le}. Just dereference the uint8_t pointer.
Yep. Not sure why I wrote in that way.


https://reviews.llvm.org/D28094