[PATCH] D29111: [SimplifyCFG] Do not sink and merge inline-asm instructions

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 21:02:02 PST 2017


majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:1440
+
+    // Conservatively return false if I is an inline-asm instruction.
+    if (const auto *C = dyn_cast<CallInst>(I))
----------------
I'd mention the constraint issue, it quickly explains why this is needed.


https://reviews.llvm.org/D29111





More information about the llvm-commits mailing list