[PATCH] D28942: [globalisel] Re-factor ISel matchers into a hierarchy. NFC

[Ahmed Bougacha via Phabricator via llvm-commits]

ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D28942#653240, @dsanders wrote:

> I should be able to use the same technique as for addPredicate() but it doesn't work. I'm looking into it.


Have you figured that out?  Other than that, LGTM;



================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:124
+template <class Predicate>
+class WithPredicates {
+private:
----------------
The name is cryptic ...but I don't have a better idea  ¯\_(ツ)_/¯

PredicateList? PredicateVector? PredicateHolder?


https://reviews.llvm.org/D28942