[PATCH] D29003: [OptDiag] Move everything but code region into a new base class for DiagnosticInfoOptimizationBase
Adam Nemet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 24 17:01:03 PST 2017
anemet updated this revision to Diff 85659.
anemet marked an inline comment as not done.
anemet added a comment.
The main thing is the renaming here proposed by Matthias.
I've actually kept the original name DiagnosticInfoOptimizationBase for the
IR-agnostic class (i.e. no code-region). This is nice because 99% of the
clients work because they weren't using code region. This includes clang so
there is no cross-repo renaming.
The other names are as suggested by Matthias.
Will also update the title and description of the review because it's
confusing now.
https://reviews.llvm.org/D29003
Files:
include/llvm/Analysis/OptimizationDiagnosticInfo.h
include/llvm/IR/DiagnosticInfo.h
lib/Analysis/OptimizationDiagnosticInfo.cpp
lib/IR/DiagnosticInfo.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29003.85659.patch
Type: text/x-patch
Size: 20767 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170125/abdef5d9/attachment.bin>
More information about the llvm-commits
mailing list