[PATCH] D29050: [zorg] Add AOSP builder

[Pengxuan Zheng via Phabricator via llvm-commits]

pzheng added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:680
+                timeout=180,
+                target_clang="../polly-arm-linux/llvm.inst/bin",
+                target_flags="-Wno-error -O3 -mllvm -polly -mllvm -polly-position=before-vectorizer -mllvm -polly-process-unprofitable",
----------------
grosser wrote:
> Instead of giving a path to the installed clang, I would prefer if we build a new clang as part of the AOSP build factory. This would make sure that the SVN id that is reported in the build actually is the one that was used to build the clang/LLVM we run here.
Sure, that makes sense. I will add another flag to control if we want to build a new clang as part of the AOSP build factory.


================
Comment at: buildbot/osuosl/master/config/builders.py:686
+                sync=True,
+                patch="aosp-O3-polly-before-vectorizer-unprofitable")}
+    ]
----------------
kristof.beyls wrote:
> My understanding is that the 'aosp-O3-polly-before-vectorizer-unprofitable' patch is local to your builder, and needed to make it possible to use a non-AOSP-version of clang to build AOSP.
> Would it be possible to also share this upstream somehow so that others could also set up AOSP builders, if wanted?
Yes, that is correct. The pre-generated patches are local to each buildslave and are needed to make it possible to use a non-AOSP-version of clang to build AOSP.

Sure, I will post the patch I use if you are interested.


https://reviews.llvm.org/D29050